Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainSpec genesis header as SealedHeader #14355

Closed
emhane opened this issue Feb 10, 2025 · 3 comments · Fixed by #14514
Closed

ChainSpec genesis header as SealedHeader #14355

emhane opened this issue Feb 10, 2025 · 3 comments · Fixed by #14514
Assignees
Labels
A-op-reth Related to Optimism and op-reth C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Feb 10, 2025

Describe the feature

Make ChainSpec store a SealedHeader instead of genesis header + hash separately

/// The hash of the genesis block.
///
/// This is either stored at construction time if it is known using [`once_cell_set`], or
/// computed once on the first access.
pub genesis_hash: OnceLock<B256>,
/// The header corresponding to the genesis block.
///
/// This is either stored at construction time if it is known using [`once_cell_set`], or
/// computed once on the first access.
pub genesis_header: OnceLock<Header>,

Additional context

Ref #14066 (comment)

@emhane emhane added C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started labels Feb 10, 2025
@DarkLord017
Copy link
Contributor

Hey @emhane , would like to work on this !

@emhane
Copy link
Member Author

emhane commented Feb 12, 2025

how is it going with this one @DarkLord017 ?

@emhane
Copy link
Member Author

emhane commented Feb 12, 2025

taking this over @DarkLord017 to unblock critical path for #13145

@emhane emhane assigned emhane and unassigned DarkLord017 Feb 12, 2025
@emhane emhane moved this to In Review in Project Tracking Feb 13, 2025
@emhane emhane added the A-op-reth Related to Optimism and op-reth label Feb 13, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 15, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Done
2 participants