Declare PayloadValidator::ExecutionPayload

[emhane]

Describe the feature

ExecutionPayload needs to be set to OpExecutionPayload in impl of trait for OpEngineValidator

reth/crates/engine/primitives/src/lib.rs

Lines 100 to 118 in 2216c8a

	/// Type that validates an [`ExecutionPayload`].
	pub trait PayloadValidator: fmt::Debug + Send + Sync + Unpin + 'static {
	/// The block type used by the engine.
	type Block: Block;
	/// Ensures that the given payload does not violate any consensus rules that concern the block's
	/// layout.
	///
	/// This function must convert the payload into the executable block and pre-validate its
	/// fields.
	///
	/// Implementers should ensure that the checks are done in the order that conforms with the
	/// engine-API specification.
	fn ensure_well_formed_payload(
	&self,
	payload: ExecutionPayload,
	sidecar: ExecutionPayloadSidecar,
	) -> Result<SealedBlock<Self::Block>, PayloadError>;
	}

Additional context

This is blocking the withdrawals root feature in isthmus, since l1 computes the withdrawals root from a list of withdrawals as opposed to serialise the root and send it over the network. OP doesn't use the withdrawals list in the block body. Instead, from isthmus on, the withdrawals root is the storage hash of L2ToL1MessagePasser.sol, so it reflects the copy of the state of the node who sends the payload.

[emhane]

possibly I misunderstood and it's intended that the execution payload validator for OP should have access to the db and should compute the withdrawals root locally, as fixed here ethereum-optimism#56? @tynes @protolambda

[emhane]

closed in #14179