Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SealedBlock.header field private #13640

Closed
mattsse opened this issue Jan 3, 2025 · 6 comments · Fixed by #13646
Closed

Make SealedBlock.header field private #13640

mattsse opened this issue Jan 3, 2025 · 6 comments · Fixed by #13646
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 3, 2025

Describe the feature

ref #13626

some progress has been made here #13633

we need to only go through functions or the deref when accessing header fields so we can easily change SealedBlock internals.

TODO

  • make header field private
  • update all breaking code

I find the easiest way to do this is

  1. make field private
  2. compile entire workspace and fix errors until it compiles: cargo clippy --bin op-reth --workspace --lib --examples --tests --locked --features "optimism"

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 3, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Jan 3, 2025
@frankudoags
Copy link
Contributor

Hi @mattsse, can I take this?

@hoank101 hoank101 mentioned this issue Jan 4, 2025
Merged
@hoank101
Copy link
Contributor

hoank101 commented Jan 4, 2025

hi, i am doing it

@bestselection18
Copy link

Could I be assigned to this?

@PoulavBhowmick03
Copy link
Contributor

Gm gm! I would love to work on this! I have some experience in Rust and have contributed to projects like Starknet Foundry and dojo. This would be my first time contributing to Reth!

@aidenwong812
Copy link

Is it okay if I take this?

@V15HNUPM
Copy link

V15HNUPM commented Jan 6, 2025

Could I be assigned to this?

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: make SealedBlock.header field private hoank101/reth
7 participants
@mattsse @frankudoags @V15HNUPM @PoulavBhowmick03 @bestselection18 @aidenwong812 @hoank101