Make payload_builder function accept BestTxterator directly

[mattsse]

Describe the feature

Currently we create the iterator like this:

reth/crates/ethereum/payload/src/lib.rs

Lines 155 to 158 in a4126b3

	let mut best_txs = pool.best_transactions_with_attributes(BestTransactionsAttributes::new(
	base_fee,
	initialized_block_env.get_blob_gasprice().map(|gasprice| gasprice as u64),
	));

in:

reth/crates/ethereum/payload/src/lib.rs

Lines 126 to 136 in a4126b3

	pub fn default_ethereum_payload<EvmConfig, Pool, Client>(
	evm_config: EvmConfig,
	args: BuildArguments<Pool, Client, EthPayloadBuilderAttributes, EthBuiltPayload>,
	initialized_cfg: CfgEnvWithHandlerCfg,
	initialized_block_env: BlockEnv,
	) -> Result<BuildOutcome<EthBuiltPayload>, PayloadBuilderError>
	where
	EvmConfig: ConfigureEvm<Header = Header>,
	Client: StateProviderFactory + ChainSpecProvider<ChainSpec = ChainSpec>,
	Pool: TransactionPool,
	{

it would be nicer if this would accept any iterator

we can make this easily work by changing the requested type of the pool

reth/crates/ethereum/payload/src/lib.rs

Line 135 in a4126b3

Pool: TransactionPool,

which should not be TxPool but something that returns a new BestTransactionsIter given a BestTransactionsAttributes, so something like

Pool: FnOnce(BestTransactionsAttributes) -> BestTransactionsIter

see also:

#11890

Additional context

No response

[edisontim]

Hello! Can I get assigned on this one?

[mahmudsudo]

Hello! Can I get assigned on this one?

[edisontim]

Hey @mattsse, I'm wondering if this is possible as we need the pool later on for ?

reth/crates/ethereum/payload/src/lib.rs

Line 379 in a4126b3

blob_sidecars = pool.get_all_blobs_exact(

Maybe I'm missing something, I apologize if that's the case

[mattsse]

I see, then we need this as extra argument instead