Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend EthApi with execution helpers #11122

Closed
mattsse opened this issue Sep 23, 2024 · 1 comment
Closed

Extend EthApi with execution helpers #11122

mattsse opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 23, 2024

Describe the feature

ref #10974

currently the ethApi impl only tracks the EvmConfig:

/// The type that defines how to configure the EVM
evm_config: EvmConfig,

it would be beneficial to have additional execution related helpers,

this could serve as the entry point that abstracts away transaction/block execution for tracing, pending block building etc.
This would also decouple execution further from eth API impl, which I believe @tcoratger would also appreciate.

what we need first, is a solution to #10974, an instance that wraps EvmConfig and knows how to execute a block.

Which can be something like: #11074

then we can also integrate the payload builder so we can easily build a pending block

The end goal would probably look like something that doesn't require EvmConfig at all.

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled S-needs-design This issue requires design work to think about how it would best be accomplished and removed S-needs-triage This issue needs to be labelled labels Sep 23, 2024
@mattsse mattsse self-assigned this Sep 23, 2024
@0x00101010
Copy link
Contributor

Hey @mattsse,

I have this PR that basically injects BlockExecutor into DebugApi for debug_execution_witess purposes, upon reading your issue here, it looks like my approach might not be the best in terms of clean interface.

Would love to get your thoughts on if the PR and if this should be tackled at another layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished
Projects
Status: Done
Development

No branches or pull requests

2 participants