Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Engine2 for Optimism #10160

Closed
Tracked by #8742
mattsse opened this issue Aug 7, 2024 · 0 comments · Fixed by #10222
Closed
Tracked by #8742

Integrate Engine2 for Optimism #10160

mattsse opened this issue Aug 7, 2024 · 0 comments · Fixed by #10222
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 7, 2024

for eth we already have:

pub struct EthNodeLauncher {

we need the same for optimism

maybe there's a way to make the setup reusable for OP by modifying:

pub struct EthService<DB, Client>
where
DB: Database + 'static,
Client: BlockClient + 'static,
{
orchestrator: EthServiceType<DB, Client>,
}

but optional for now

TODO

  • make it possible to launch OP with new engine, same as:

if let Err(err) = Cli::<EngineArgs>::parse().run(|builder, engine_args| async move {
let enable_engine2 = engine_args.experimental;
match enable_engine2 {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants