Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commands to be in line with current Python Inky #28

Open
lawik opened this issue Jul 25, 2019 · 3 comments
Open

Update commands to be in line with current Python Inky #28

lawik opened this issue Jul 25, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@lawik
Copy link
Collaborator

lawik commented Jul 25, 2019

A bunch of magical numbers, voltages and stuff have been changed.

Example, the stuff sent for the yellow display specifics has been changed:
pimoroni/inky@8165ca0

So we should get up to scratch with that.
@nyaray
Copy link
Collaborator

nyaray commented Jul 26, 2019

Does this include #9?

@lawik
Copy link
Collaborator Author

lawik commented Jul 26, 2019

It could. But it doesn't have to. I think #9 would be worth doing on its own, has some additional requirements (reading the EEPROM iirc). So I'd say keeping them separate makes things easier.

This could probably just be a straight pass to adjust our numbers to be in line with the tweaks they seem to have made. From what I've seen, some things like yellow color temperature by passing different stuff for the yellow-specific commands seem to have been changed.

@lawik lawik added the enhancement New feature or request label Jul 26, 2019
@nyaray
Copy link
Collaborator

nyaray commented Jul 26, 2019

Sounds good, agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyaray @lawik