Replace Assert with Return #1204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node's native `assert()` can be very heavy, especially in a large project
with a source map as it creates a full stack trace on failure.
In practice, we were seeing negative responses to model.find() taking
up to 2 seconds to resolve.
Most assertions in this library are either for config or use Koa's `assert`
method, which uses a considerably lighter code-path.
Replacing with if `(!stored) { return }` is an effectively free
operation.
panva
reviewed
Sep 29, 2022
|
Moved. 😀 |
|
I'll go through the rest of the hot path asserts and replace them. Since i'm not able to push to your upstream I'll do the rest of the work in #1205 where i've kept you as co-author. |
|
No problem, thanks for that. It's a big library and I'm a little unsure what should and shouldn't be altered. 😅 |
panva
force-pushed
the
main
branch
4 times, most recently
from
18906ce to
e969c39
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node's native
assert()can be very heavy, especially in a large project with a source map as it creates a full stack trace on failure.In practice, we were seeing negative responses to
model.find()taking up to 2 seconds to resolve.Most assertions in this library are either for config or use Koa's
assertmethod, which uses a considerably lighter code-path.Replacing with if
(!stored) { return }is an effectively free operation and solved our performance issues on negative responses.