Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly check access token audience when issuing ID tokens #1038

Merged
merged 1 commit into from
Jun 24, 2021
Merged

fix: correctly check access token audience when issuing ID tokens #1038

merged 1 commit into from
Jun 24, 2021

Conversation

roc13x
Copy link
Contributor

@roc13x roc13x commented Jun 24, 2021

Fixes an issue where ID tokens would not include account claims, even if the access token was not usable for the userInfo endpoint (contained an aud value).

Currently, if you use the resourceIndicators feature and issue an access token in JWT format, then the returned ID token will not contain any account claims. This is despite the fact that the JWT access token is not usable on the userInfo endpoint.

Problem is caused by the code checking the access token for an aud value. It's checking the generated token string rather then the original token object.

@panva
Copy link
Owner

panva commented Jun 24, 2021

@roc13x nice catch, thank you for bringing it up.

@panva panva merged commit 4b16c71 into panva:main Jun 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants