Fix Tox not finding Python 3.8 on OSX. #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
force-pushed
the
ci/osx/3.8/fix-find-interpreter
branch
9 times, most recently
from
3cba840 to
196b3b9
Compare
This works, but I can't explain why the prior did not. Moving on with the fix though since real green is better than the current early exit green due to not being able to find Python 3.8 and having our tox.ini configured for `skip_missing_interpreters = True`. Patch that by adding `--skip-missing-interpreters=false` to our tox invocations in CI.
jsirois
force-pushed
the
ci/osx/3.8/fix-find-interpreter
branch
from
3ac6767 to
70a2939
Compare
jsirois
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but I can't explain why the prior did not. Moving on with
the fix though since real green is better than the current early exit
green due to not being able to find Python 3.8 and having our tox.ini
configured for
skip_missing_interpreters = True. Patch that by adding--skip-missing-interpreters=falseto our tox invocations in CI.