Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox -epackage to create pex supporting 3.8. #843

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jan 6, 2020

This was missed in #826 but noticed creating #842 where pex.pex startup
was slower than expected due to not using the current (python 3.8)
interpreter and instead proceeding to find all interpreters and then
select the min.

This was missed in pex-tool#826 but noticed creating pex-tool#842 where pex.pex startup
was slower than expected due to not using the current (python 3.8)
interpreter and instead proceeding to find all interpreters and then
select the min.
@jsirois jsirois requested a review from Eric-Arellano January 6, 2020 04:00
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than a typo in title. s/-epackage/-e package.

@jsirois
Copy link
Member Author

jsirois commented Jan 6, 2020

Looks good, other than a typo in title. s/-epackage/-e package.

Not a typo, I try to abide by the linux kernel commit formatting conventions which calls for a 50 column summary sentence and then 72 column body. tox -epackage is a valid command line and in fact the way I spell my tox invocations (no space).

@jsirois jsirois merged commit a2b6d0a into pex-tool:master Jan 6, 2020
@jsirois jsirois deleted the pex.pex/support-python3.8-runtime branch January 6, 2020 05:04
@jsirois jsirois mentioned this pull request Jan 22, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants