Support the latest Pip releases: 22.3.1 & 23.0 #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
commented
Feb 12, 2023
| @@ -65,10 +65,10 @@ jobs: | |||
| pip-version: 20 | |||
| - os: ubuntu-20.04 | |||
| python-version: [ 3, 11 ] | |||
| pip-version: 22_2 | |||
| pip-version: 22_3_1 | |||
There was a problem hiding this comment.
I just rolled off 22.2 and 22.3 here; so they are no longer covered. I figure, to be sustainable, I have to do something like this. The rolled-off Pips will have had a good long hammering during their time in CI; and assuming these 2 slots span just 1 ~major version bump (Pip actually uses the last 2 digits of the year for major; so it's not semver major - god love Pip), It seems incredibly unlikely this will lead to issues. If the runtime patches have to change in a way that does not support older versions of Pip, I'll revisit of course, but right now the patches work across all supported Pip versions.
…ed after Pip, so pin back.
benjyw
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.