Fix --venv PEX PEX_EXTRA_SYS_PATH propagation.
#1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this used `PYTHONPATH` for propagation, which could lead to issues executing foreign Pythons in subprocesses. Switch to using a `.pth` file. Although the problem of polluting foreign Pythons in subprocesses remains for zipapp PEXes, it is the case that `--venv` is Pex's maximum compatibility mode and this can be viewed as yet another case where a Pex feature breaking a Python app should be solved by using `--venv` mode. Fixes pex-tool#1836
|
N.B.: The pre-existing tests from #989 and #1832 vet this. In particular, the following test added in #1832 brought to light the issue with This test failed in |
|
I did verify that this Pex causes |
benjyw
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this used
PYTHONPATHfor propagation, which could lead toissues executing foreign Pythons in subprocesses. Switch to using a
.pthfile. Although the problem of polluting foreign Pythons insubprocesses remains for zipapp PEXes, it is the case that
--venvisPex's maximum compatibility mode and this can be viewed as yet another
case where a Pex feature breaking a Python app should be solved by using
--venvmode.Fixes #1836