Fix pex --lock ... handling of sdists.
#1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Pex 2.1.93, sdists that built native extensions or used a PEP-517 build system would not be successfully downloaded when constructing a PEX from a lock. Fixes pex-tool#1817
jsirois
commented
Jul 1, 2022
| ).assert_success() | ||
|
|
||
|
|
||
| def test_sdist_for_project_universal(tmpdir): |
There was a problem hiding this comment.
N.B.: This test passed prior to the fix but the following two tests failed.
benjyw
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Pex 2.1.93, sdists that built native extensions or used a PEP-517
build system would not be successfully downloaded when constructing a
PEX from a lock.
Fixes #1817