Fix lock save detection to be more robust. #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the save was qualified against the download directory, but this led to missed save identifications when the download directory was relative to the CWD. Since there is only one type of save going on during a download, just capture them all regardless of path since they're all in the download directory anyhow. Fixes pex-tool#1758
benjyw
approved these changes
May 14, 2022
Eric-Arellano
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the save was qualified against the download directory, but
this led to missed save identifications when the download directory was
relative to the CWD. Since there is only one type of save going on
during a download, just capture them all regardless of path since
they're all in the download directory anyhow.
Fixes #1758