Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious InstalledDistribution env markers. #1104

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Nov 7, 2020

Elide environment markers for arbitrary equality (distributions with
non-standard versions).

Fixes #940

Elide environment markers for arbitrary equality (distributions with
non-standard versions).

Fixes pex-tool#940
@jsirois
Copy link
Member Author

jsirois commented Nov 7, 2020

Added tests fail in the same way seen in #940 with the new === short-circuiting code commented out.

This was previously leaving CWD to a deleted tmp dir poisoning
downstream tests.
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@jsirois jsirois merged commit ff8a852 into pex-tool:master Nov 7, 2020
@jsirois jsirois deleted the issues/940 branch November 7, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid requirement, parse error at "'python_v'
2 participants