Add atomic_directory exclusive mode. #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this new mode to ensure directories Pex creates that contain Python code are created exactly once so that the implicit Python bytecode compilation process is not thwarted by racing directory creation. Fixes pex-tool#1051
Eric-Arellano
approved these changes
Oct 8, 2020
pex/common.py
Outdated
| @@ -318,12 +319,16 @@ def cleanup(self): | |||
|
|
|||
|
|
|||
| @contextmanager | |||
| def atomic_directory(target_dir, source=None): | |||
| def atomic_directory(target_dir, source=None, exclusive=False): | |||
There was a problem hiding this comment.
Thoughts on not using a default for exclusive, so that call sites must decide what to do? This was a subtle bug - I fear future changes won't realize they need to set exclusive=True, and won't realize they have a race condition until someone hits in the wild.
Eric-Arellano
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this new mode to ensure directories Pex creates that contain Python
code are created exactly once so that the implicit Python bytecode
compilation process is not thwarted by racing directory creation.
Fixes #1051