Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PEX_HTTP_RETRIES and push into a flag for the pex tool #94

Closed
wickman opened this issue Apr 17, 2015 · 2 comments · Fixed by #974
Closed

Remove PEX_HTTP_RETRIES and push into a flag for the pex tool #94

wickman opened this issue Apr 17, 2015 · 2 comments · Fixed by #974
Assignees
@jsirois

Comments

@wickman
Copy link
Contributor

wickman commented Apr 17, 2015

PEX_* environment variables are reserved for the PEX runtime. Everything else should ideally be a flag to the pex tool or used via the API directly.
@jsirois
Copy link
Member

jsirois commented May 7, 2019

#726 grew PEX_HTTP_TIMEOUT which should be moved as well.

@jsirois jsirois self-assigned this May 7, 2019
This was referenced May 7, 2019
Closed
Merged
@jsirois jsirois mentioned this issue Jun 24, 2019
Closed
6 tasks
@jsirois
Copy link
Member

jsirois commented May 11, 2020

This is related to fixing #803.

jsirois added a commit to jsirois/pex that referenced this issue May 11, 2020
@jsirois
Expose Pip network configuration.
4289ab8 
Also add back the `--cache-ttl` option from Pex 1.x and plumb the header
needed to make it so.

Also remove long-ignored `PEX_HTTP_RETRIES` and `PEX_HTTP_TIMEOUT` env
var support.

Fixes pex-tool#94
Fixes pex-tool#803
@jsirois jsirois mentioned this issue May 11, 2020
Merged
jsirois added a commit that referenced this issue May 12, 2020
@jsirois @Eric-Arellano
Expose Pip network configuration. (#974)
451977e 
Also add back the `--cache-ttl` option from Pex 1.x and plumb the header
needed to make it so.

Also remove long-ignored `PEX_HTTP_RETRIES` and `PEX_HTTP_TIMEOUT` env
var support.

Fixes #94
Fixes #803

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Pip network configuration. jsirois/pex
2 participants
@jsirois @wickman