Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Conan stdout parsing #6168

Closed
CMLivingston opened this issue Jul 17, 2018 · 2 comments
Closed

Improve Conan stdout parsing #6168

CMLivingston opened this issue Jul 17, 2018 · 2 comments

Comments

@CMLivingston
Copy link
Contributor

CMLivingston commented Jul 17, 2018 •
edited
Loading

As of #5998, Pants has support for 3rdparty C++ dependencies for the ctypes native library target by leveraging the Conan project.

The task that executes the fetching of these 3rdparty deps currently does some string operations to parse the Conan package sha from standard output. The scope of this ticket is to either replace this parse method with a regex match, or communicate with upstream Conan to get a JSON output mode for the client that is readily-parsable by Pants. Then, add adequate test cases that cover all possible Conan client outputs.
@stuhood
Copy link
Member

stuhood commented Jul 17, 2018 •
edited
Loading

If possible, adding a JSON output mode upstream would be preferable to using regexes.

@CMLivingston CMLivingston changed the title Implement robust regex matching for Conan stdout parsing Improve Conan stdout parsing Jul 17, 2018
@Eric-Arellano
Copy link
Contributor

Closing as stale. From what I can tell, no one has plans to work on Conan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stuhood @CMLivingston @Eric-Arellano