Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand product_request() and (maybe) deprecate ExecutionRequest #6044

Closed
cosmicexplorer opened this issue Jun 28, 2018 · 1 comment
Closed

Comments

@cosmicexplorer
Copy link
Contributor

See this comment by @stuhood in #5943. product_request() or product_requests() are (in my opinion) easier to use than the ExecutionRequest API, and don't introduce a (seemingly) unnecessary step of creating a request to be executed. There are few enough users of ExecutionRequest that we can consider deprecating it, if we can add a "list of tuples" type method (described in the linked comment) for the product_request() family of methods.

@Eric-Arellano
Copy link
Contributor

Closing as this has been superseded by the V2 engine / Rules API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants