Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gen.go-thrift skippable #5003

Closed
baroquebobcat opened this issue Oct 19, 2017 · 1 comment
Closed

Make gen.go-thrift skippable #5003

baroquebobcat opened this issue Oct 19, 2017 · 1 comment

Comments

@baroquebobcat
Copy link
Contributor

go-thrift apparently can generate invalid source code. It would be handy to be able to skip generating it by default.

More broadly, I think whether all tasks should be skippable or not is an interesting question to resolve.

@stuhood
Copy link
Member

stuhood commented May 4, 2018

I think that the whole "skip" concept is going to be fundamentally different in the new engine: skipping nodes out of the middle of a graph will just never make sense, so this would become more a question of root selection. So I think I'm just going to link this to #4769 and resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants