-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Target
cacheable in the ProductGraph
#3991
Milestone
Comments
sgtm. |
This was referenced Feb 6, 2018
Closed
It seems likely that this should be dropped entirely in favor of #4769, which proposes to not create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
currently,
BuildGraph
construction is responsible for the ~majority of our runtime in the warm case. much of the cost here lies inTarget
instantiation which happens on each run by way of converting cachedLegacyTarget
/TargetAdaptor
objects.if we can instead construct
Target
objects directly in the daemon+engine context and thus make them cacheable in the residentProductGraph
, then we can theoretically skirt their construction costs on warm runs and simply link them together within a per-runBuildGraph
.in order to do this, we'll probably have to:
Target
->BuildGraph
linkagesThe text was updated successfully, but these errors were encountered: