You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When testing v2 engine in master, I found that LegacyAddressMapper does not have scan_build_files method, which is used by a few tasks. To make all integration tests in master pass on v2 engine, we have to extend the interface coverage of LegacyAddressMapper.
As part of the effort, LegacyAddressMapper should be v2 engine backed (similar to LegacyBuildGraph), which means the new scan_build_files method, along with all existing methods, should be implemented using v2 engine directly.
The text was updated successfully, but these errors were encountered:
When testing v2 engine in master, I found that LegacyAddressMapper does not have scan_build_files method, which is used by a few tasks. To make all integration tests in master pass on v2 engine, we have to extend the interface coverage of LegacyAddressMapper.
As part of the effort, LegacyAddressMapper should be v2 engine backed (similar to LegacyBuildGraph), which means the new scan_build_files method, along with all existing methods, should be implemented using v2 engine directly.
The text was updated successfully, but these errors were encountered: