Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using OneLogin Simple SAML toolkit for PHP #60

Closed
danielbachhuber opened this issue Mar 22, 2017 · 8 comments
Closed

Consider using OneLogin Simple SAML toolkit for PHP #60

danielbachhuber opened this issue Mar 22, 2017 · 8 comments
Assignees
Milestone

Comments

@danielbachhuber
Copy link
Contributor

OneLogin has a Simple SAML toolkit for PHP, which looks robust. We may be able to package this directly with the plugin, instead of requiring SimpleSAMLphp to be installed separately.

@stevector
Copy link
Contributor

Last year @davidstrauss mentioned positively it in Power Users: https://groups.google.com/a/pantheon.io/d/msg/power-users/uBHYj1c8lqY/PsIbFvZHEgAJ

From what I see it looks like a much nicer option. And between LCache and Solr Power we have better conventions for handling a Composer dependency like OneLogin's library than what is currently recommended here with SimpleSAML.

@joshkoenig
Copy link
Member

+1 for this. There was a time when I thought that SimpleSamlPHP support was important, and retaining it as an option could be nice.

HOWEVER - if we can do SAML out of the box with OneLogin's library, operating as a Service Provider only, and with a single configuration file to set up, that would be... preferable. Worth a spike at least.

@tobeycodes
Copy link

tobeycodes commented May 23, 2017

@danielbachhuber what's the status of this? Just integrated a site with this plugin and SimpleSamlPHP. No rush, just want to put it into the timeline to switch

@stevector how do you currently handle this? I opted with a post composer hook to rsync the config, certs and metadata to the vendor/simplesamlphp folder

@danielbachhuber
Copy link
Contributor Author

@schrapel Functional work in progress on #68. Remaining work is:

  • Fix failing integration tests.
  • Document setup.

@stevector
Copy link
Contributor

@schrapel I haven't used the onelogin library myself yet.

I opted with a post composer hook to rsync the config, certs and metadata to the vendor/simplesamlphp folder

I assume you are using the web_docroot option such that your vendor directory is not web accessible?

@tobeycodes
Copy link

tobeycodes commented May 24, 2017 via email

@stevector
Copy link
Contributor

Ah, right. rsync after Composer install/update makes sense to me. To set up a site for the Behat tests we just do a lot of file copying/wrangling. https://github.com/pantheon-systems/wp-saml-auth/blob/master/bin/behat-prepare.sh It's not very elegant.

@danielbachhuber
Copy link
Contributor Author

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants