Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #241

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Minor fixes #241

merged 4 commits into from
Feb 3, 2025

Conversation

ksikka
Copy link
Collaborator

@ksikka ksikka commented Feb 3, 2025

  1. For csv_file prediction, change data_dir default from csv_file.parent to cfg.data.data_dir
  2. Resolve csv_file to absolute path before prediction. Reason being that CLI deals with paths relative to current working directory, while downstream assumes csv_file is relative to data_dir.
  3. Update downstream code to be able to handle CSV file as absolute path.

@themattinthehatt themattinthehatt merged commit c1a9a96 into paninski-lab:main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themattinthehatt themattinthehatt themattinthehatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksikka @themattinthehatt