Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: More precise NaT stubs #60003

Closed
1 of 3 tasks
randolf-scholz opened this issue Oct 8, 2024 · 0 comments · Fixed by #60002
Closed
1 of 3 tasks

TYP: More precise NaT stubs #60003

randolf-scholz opened this issue Oct 8, 2024 · 0 comments · Fixed by #60002
Labels
Enhancement Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@randolf-scholz
Copy link
Contributor

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

Amendment to #59996. The current stub has some imprecise typing.

Feature Description

  • inequalities do not cover comparisons of NaTType with itself.
  • addition/subtraction does not cover pd.Period and numpy types.
  • dunder methods should be marked with positional-only parameters, even if the class supports keyword usage.

Alternative Solutions

N/A

Additional Context

No response
@randolf-scholz randolf-scholz added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 8, 2024
@randolf-scholz randolf-scholz mentioned this issue Oct 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typing: More precise NaT stub randolf-scholz/pandas
1 participant
@randolf-scholz