Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: pd.to_numeric(timedelta_scalar) raises TypeError #59944

Closed
2 of 3 tasks
sfc-gh-mvashishtha opened this issue Oct 2, 2024 · 2 comments · Fixed by #59974
Closed
2 of 3 tasks

BUG: pd.to_numeric(timedelta_scalar) raises TypeError #59944

sfc-gh-mvashishtha opened this issue Oct 2, 2024 · 2 comments · Fixed by #59974
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Timedelta Timedelta data type Timestamp pd.Timestamp and associated methods
Milestone

Comments

@sfc-gh-mvashishtha
Copy link

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd

pd.to_numeric(pd.Timedelta(1))

Issue Description

Getting a TypeError

Expected Behavior

For the example above, I should get the integer 1. That would match the behavior of pd.to_numeric(pd.Series(pd.Timedelta(1)))

Installed Versions

INSTALLED VERSIONS
------------------
commit                : 0691c5cf90477d3503834d983f69350f250a6ff7
python                : 3.9.18
python-bits           : 64
OS                    : Darwin
OS-release            : 23.6.0
Version               : Darwin Kernel Version 23.6.0: Wed Jul 31 20:48:52 PDT 2024; root:xnu-10063.141.1.700.5~1/RELEASE_ARM64_T6020
machine               : arm64
processor             : arm
byteorder             : little
LC_ALL                : None
LANG                  : en_US.UTF-8
LOCALE                : en_US.UTF-8

pandas                : 2.2.3
numpy                 : 1.26.3
pytz                  : 2023.3.post1
dateutil              : 2.8.2
pip                   : 23.3.1
Cython                : None
sphinx                : None
IPython               : 8.18.1
adbc-driver-postgresql: None
adbc-driver-sqlite    : None
bs4                   : None
blosc                 : None
bottleneck            : None
dataframe-api-compat  : None
fastparquet           : None
fsspec                : None
html5lib              : None
hypothesis            : None
gcsfs                 : None
jinja2                : None
lxml.etree            : None
matplotlib            : None
numba                 : None
numexpr               : None
odfpy                 : None
openpyxl              : None
pandas_gbq            : None
psycopg2              : None
pymysql               : None
pyarrow               : None
pyreadstat            : None
pytest                : 8.3.2
python-calamine       : None
pyxlsb                : None
s3fs                  : None
scipy                 : None
sqlalchemy            : None
tables                : None
tabulate              : None
xarray                : None
xlrd                  : None
xlsxwriter            : None
zstandard             : None
tzdata                : 2023.4
qtpy                  : None
pyqt5                 : None
@sfc-gh-mvashishtha sfc-gh-mvashishtha added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 2, 2024
@rhshadrach
Copy link
Member

Thanks for the report, confirmed on main. With a Series, to_numeric has logic for NumPy dtypes "mM" to handle this case, but there is no corresponding logic for scalars. Further investigations and PRs to fix are welcome!

@rhshadrach rhshadrach added Dtype Conversions Unexpected or buggy dtype conversions Timedelta Timedelta data type and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 2, 2024
@yuanx749
Copy link
Contributor

yuanx749 commented Oct 5, 2024

Getting the same error for Timestamp scalar too. I think a quick fix could work.

@rhshadrach rhshadrach added this to the 3.0 milestone Oct 5, 2024
@rhshadrach rhshadrach added the Timestamp pd.Timestamp and associated methods label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Timedelta Timedelta data type Timestamp pd.Timestamp and associated methods
Projects
None yet
3 participants