Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: add pylint pre-commit hook #48737

Closed
MarcoGorelli opened this issue Sep 23, 2022 · 6 comments · Fixed by #48759
Closed

STYLE: add pylint pre-commit hook #48737

MarcoGorelli opened this issue Sep 23, 2022 · 6 comments · Fixed by #48759
Labels
Code Style Code style, linting, code_checks good first issue

Comments

@MarcoGorelli
Copy link
Member

Having pylint in CI would've prevented a bug from entering 1.5.0 #48736

So let's add pylint as a pre-commit hook

pylint has a lot of options - some duplicative of what's already in flake8, others arguably too opinionated, others that we'd like to eventually enable but perhaps not all in one go

So, the task here is:

@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks good first issue labels Sep 23, 2022
@YvanCywan
Copy link
Contributor

Would you mind if I took a look at this?

@MarcoGorelli
Copy link
Member Author

go ahead, thanks

@YvanCywan
Copy link
Contributor

Okay, so at the moment, I have disabled checks for Convention Checks, Refactoring Checks and general warnings (there are far too many to go through).

All that should appear are potential bugs (errors) and fatal errors. I will go through and see what I can do about the bugs that appear, does this sound fine?

@MarcoGorelli
Copy link
Member Author

sounds good! can always just add the check with all but a few potential bugs / fatal errors turned off, and then we gradually turn the others on as we fix them in separate PRs

@YvanCywan
Copy link
Contributor

Alright then, sounds good, I should be done soon then. I'll submit the PR when ready.

@YvanCywan
Copy link
Contributor

YvanCywan commented Sep 24, 2022

PR #48759 Submitted, no changes to codebase, only pylint CI integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants