-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: add pylint pre-commit hook #48737
Comments
Would you mind if I took a look at this? |
go ahead, thanks |
Okay, so at the moment, I have disabled checks for Convention Checks, Refactoring Checks and general warnings (there are far too many to go through). All that should appear are potential bugs (errors) and fatal errors. I will go through and see what I can do about the bugs that appear, does this sound fine? |
sounds good! can always just add the check with all but a few potential bugs / fatal errors turned off, and then we gradually turn the others on as we fix them in separate PRs |
Alright then, sounds good, I should be done soon then. I'll submit the PR when ready. |
PR #48759 Submitted, no changes to codebase, only pylint CI integration. |
Having pylint in CI would've prevented a bug from entering 1.5.0 #48736
So let's add pylint as a pre-commit hook
pylint has a lot of options - some duplicative of what's already in
flake8
, others arguably too opinionated, others that we'd like to eventually enable but perhaps not all in one goSo, the task here is:
pylint
to https://github.com/pandas-dev/pandas/blob/main/.pre-commit-config.yamlpre-commit run pylint --all-files
pre-commit run pylint --all-files
passes, then stage, commit, and push! Feel free to tag me in the PRThe text was updated successfully, but these errors were encountered: