Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Make deprecate_nonkeyword_arguments alter function signature #48692

Closed
1 of 3 tasks
hauntsaninja opened this issue Sep 21, 2022 · 1 comment · Fixed by #48693
Closed
1 of 3 tasks

ENH: Make deprecate_nonkeyword_arguments alter function signature #48692

hauntsaninja opened this issue Sep 21, 2022 · 1 comment · Fixed by #48693
Labels
Deprecate Functionality to remove in pandas Enhancement

Comments

@hauntsaninja
Copy link
Contributor

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

Currently deprecate_nonkeyword_arguments does not alter the function signature. This means that help and ?? will show the deprecated signatures. This also affects recent attempts to achieve better typing of pandas using stubtest, e.g. see #47817 (review) and python/mypy#13703

Feature Description

Set the __signature__ attr on the decorated function

Alternative Solutions

Wait for all the removals to take place

Additional Context

No response
@hauntsaninja hauntsaninja added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 21, 2022
@hauntsaninja hauntsaninja mentioned this issue Sep 21, 2022
Merged
5 tasks
@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Sep 21, 2022 •
edited
Loading

Opened PR at #48693 cc @twoertwein

@lithomas1 lithomas1 added Deprecate Functionality to remove in pandas and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 22, 2022
@MarcoGorelli MarcoGorelli mentioned this issue Sep 23, 2022
Closed
3 tasks
@mvashishtha mvashishtha mentioned this issue Oct 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Make deprecate_nonkeyword_arguments alter function signature hauntsaninja/pandas
2 participants
@hauntsaninja @lithomas1