Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use Skipif Decorators in 'test_excel.py' #19816

Closed
WillAyd opened this issue Feb 21, 2018 · 0 comments · Fixed by #19829
Closed

TST: Use Skipif Decorators in 'test_excel.py' #19816

WillAyd opened this issue Feb 21, 2018 · 0 comments · Fixed by #19829
Labels
good first issue IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Milestone

Comments

@WillAyd
Copy link
Member

WillAyd commented Feb 21, 2018

xref #19803

The skip_if_no* methods in test_excel.py could all be replaced with the skip_if_no decorator that was introduced in #18765

import pandas.util._test_decorators as td

@td.skip_if_no('xlwt')
def foo(self):
  ...

@td.skip_if_no('xlrd', min_version='0.9')
def bar(self):
  ...
@WillAyd WillAyd changed the title Use Skipif Decorators in 'test_excel.py' TST: Use Skipif Decorators in 'test_excel.py' Feb 21, 2018
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel Effort Medium good first issue labels Feb 21, 2018
@TomAugspurger TomAugspurger added this to the Next Major Release milestone Feb 21, 2018
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants