From 017d272e77270c23ab8e78912c64b76f32fc45b6 Mon Sep 17 00:00:00 2001 From: jschendel Date: Mon, 14 Aug 2017 13:33:30 -0600 Subject: [PATCH] Review related fixes --- doc/source/whatsnew/v0.21.0.txt | 4 ++-- pandas/tests/indexes/test_interval.py | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/doc/source/whatsnew/v0.21.0.txt b/doc/source/whatsnew/v0.21.0.txt index 99fa4b0a5aa62..5ac1984b6a519 100644 --- a/doc/source/whatsnew/v0.21.0.txt +++ b/doc/source/whatsnew/v0.21.0.txt @@ -310,7 +310,8 @@ Conversion - Bug in assignment against datetime-like data with ``int`` may incorrectly converte to datetime-like (:issue:`14145`) - Bug in assignment against ``int64`` data with ``np.ndarray`` with ``float64`` dtype may keep ``int64`` dtype (:issue:`14001`) -- Bug in the return type of ``IntervalIndex.is_non_overlapping_monotonic``, which returned ``numpy.bool_`` instead of Python ``bool`` (:issue:`17237`) +- Fixed the return type of ``IntervalIndex.is_non_overlapping_monotonic`` to be a Python ``bool`` for consistency with similar attributes/methods. Previously returned a ``numpy.bool_``. (:issue:`17237`) +- Bug in ``IntervalIndex.is_non_overlapping_monotonic`` when intervals are closed on both sides and overlap at a point (:issue:`16560`) Indexing ^^^^^^^^ @@ -386,4 +387,3 @@ Other - Bug in :func:`eval` where the ``inplace`` parameter was being incorrectly handled (:issue:`16732`) - Bug in ``.isin()`` in which checking membership in empty ``Series`` objects raised an error (:issue:`16991`) - Bug in :func:`unique` where checking a tuple of strings raised a ``TypeError`` (:issue:`17108`) -- Bug in ``IntervalIndex.is_non_overlapping_monotonic`` when intervals are closed on both sides and overlap at a point (:issue:`16560`) diff --git a/pandas/tests/indexes/test_interval.py b/pandas/tests/indexes/test_interval.py index 92cec5bb1d29f..18eefc3fbdca6 100644 --- a/pandas/tests/indexes/test_interval.py +++ b/pandas/tests/indexes/test_interval.py @@ -683,11 +683,6 @@ def f(): pytest.raises(ValueError, f) def test_is_non_overlapping_monotonic(self): - # Verify that a Python Boolean is returned (GH17237) - for closed in ('left', 'right', 'neither', 'both'): - idx = IntervalIndex.from_breaks(range(4), closed=closed) - assert type(idx.is_non_overlapping_monotonic) is bool - # Should be True in all cases tpls = [(0, 1), (2, 3), (4, 5), (6, 7)] for closed in ('left', 'right', 'neither', 'both'):