feat(text): Add styled system { layout } style to Text #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefHutch
requested review from
Chef-Chungus,
hachiojidev and
RabbitDoge
as code owners
|
I'm not sure it's worth to add a prop for this. And if we really want, use this https://styled-system.com/api#layout |
ChefHutch
changed the title
ChefHutch
changed the title
ChefHutch
commented
May 10, 2021
| @@ -1,33 +1,33 @@ | |||
| import styled from "styled-components"; | |||
| import Text from "../Text/Text"; | |||
| import { tags, sizes, HeadingProps } from "./types"; | |||
| import { tags, scales, HeadingProps } from "./types"; | |||
There was a problem hiding this comment.
- As
sizeis a reserved styled-systemlayoutprop, I've renamed this prop in<Heading>to 'scale' - this matches the sizing props pattern used throughout the codebase (Button, Checkbox, Input, Toggle, Progress, Radio, Tag, Toggle) - If we are happy with this change, I'll prepare FE & Exchange PRs changing this prop value throughout the codebase.
|
Yea good point @RabbitDoge. I still think having access to the Can I get a re-up on the review? |
Chef-Cheems
approved these changes
May 10, 2021
hachiojidev
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I have needed to restyle the
<Text>component to have the display property: inline, for example when piecing together a single piece of text with different styles:Or, a
<Balance>component, preceded by a~Both of these examples require a styled component to be initialised, with the required
displaystyle.As per CR feedback - I am passing the styled system
{ layout }styles to our Text component, allowing us to pass this display style as a prop, rather than needing to declare a styled component.Breaking changes
sizeis a reserved styled-systemlayoutprop, I've renamed this for headings to 'scale' - this matches the sizing props pattern used throughout the codebase (Button, Checkbox, Input, Toggle, Progress, Radio, Tag, Toggle)