feat: Token List #95
Merged
feat: Token List #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chef-Cheems
requested review from
Chef-Chungus,
hachiojidev and
RabbitDoge
as code owners
hachiojidev
approved these changes
May 7, 2021
RabbitDoge
reviewed
May 7, 2021
packages/token-lists/package.json
Outdated
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "pancakeswap-token-lists", | |||
There was a problem hiding this comment.
@pancakeswap/tokens-lists
RabbitDoge
reviewed
May 7, 2021
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "pancakeswap-token-lists", | |||
| "version": "2.10.0", | |||
There was a problem hiding this comment.
@RabbitDoge this is the version of the list we have right now in the exchange
RabbitDoge
reviewed
May 7, 2021
| "ts-jest": "^26.5.6" | ||
| }, | ||
| "dependencies": { | ||
| "@uniswap/token-lists": "^1.0.0-beta.21", |
There was a problem hiding this comment.
This provides validation schema. We could of course copy it here 😅
RabbitDoge
reviewed
May 7, 2021
packages/token-lists/src/index.ts
Outdated
| @@ -0,0 +1,3 @@ | |||
| import buildList from "./buildList"; | |||
|
|
|||
| console.log(JSON.stringify(buildList(), null, 2)); | |||
There was a problem hiding this comment.
rather use .info the user of .log is disabled in all our codebase (for debug only)
Chef-Cheems
force-pushed
the
feature/token-lists
branch
3 times, most recently
from
fa5f939 to
5816538
Compare
hachiojidev
approved these changes
May 13, 2021
RabbitDoge
approved these changes
May 24, 2021
Chef-Cheems
force-pushed
the
feature/token-lists
branch
from
5f0063a to
452143a
Compare
hachiojidev
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a draft cause there are some details to discuss in Slack.