New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal-bg): Add overflow hidden prop to Modal container and update storybook #82

Merged

hachiojidev merged 2 commits into pancakeswap:master from ChefHutch:feature/modal-background-overflow

Apr 22, 2021

Contributor

ChefHutch commented Apr 21, 2021

Current application of the background style to <ModalHeader/> mean it blasts over its parent <ModalContainer/>'s border radius, resulting in:

Added overflow: hidden; to modal container
Fixed up some proptypes in the Modal story


          feat(modal-bg): Add overflow hidden prop to modal and update storybook

7af32a2

ChefHutch requested review from Chef-Chungus, hachiojidev and RabbitDoge as code owners

April 21, 2021 11:15

ChefHutch self-assigned this


          test(modal): Update snaps

b71fec8

hachiojidev approved these changes

View reviewed changes

hachiojidev merged commit 2233499 into pancakeswap:master

ChefHutch deleted the feature/modal-background-overflow branch

April 22, 2021 08:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet