feat(colors): Add card gradients to colors theme #61
Conversation
…cardHeaderBackground
packages/pancake-uikit/src/__tests__/components/buttonmenu.test.tsx
Outdated
Show resolved
Hide resolved
| @@ -32,6 +32,11 @@ export const lightColors: Colors = { | |||
| card: "#FFFFFF", | |||
| gradients: { | |||
| bubblegum: "linear-gradient(139.73deg, #E6FDFF 0%, #F3EFFF 100%)", | |||
| cardBackground: { | |||
There was a problem hiding this comment.
imo this should ba at the root like bubblegum (generic color)
There was a problem hiding this comment.
Sure,
gradients: {
bubblegum: "linear-gradient(139.73deg, #313D5C 0%, #3D2A54 100%)",
cardBackgroundDefault: "linear-gradient(166.77deg, #3B4155 0%, #3A3045 100%)",
cardBackgroundBlue: "linear-gradient(180deg, #00707F 0%, #19778C 100%)",
cardBackgroundViolet: "linear-gradient(180deg, #6C4999 0%, #6D4DB2 100%)",
},?
Or should we get bugs to come up with some fun, thematic names?
There was a problem hiding this comment.
Bubblegum is what is was called in Figma.
There was a problem hiding this comment.
Updated this to remove nesting & reflect Figma color scheme
| cardBackground: { | ||
| default: string; | ||
| blue: string; | ||
| violet: string; | ||
| }; |
There was a problem hiding this comment.
The Gradients object should only be top-level values, i.e. no cardBackground. That means however we will need to come up with a name for default
There was a problem hiding this comment.
Yea makes sense not to nest them. Let me ping Bugs for some inspiration on 'default'
There was a problem hiding this comment.
Updated this to remove nesting & reflect Figma color scheme
… color theme nesting
theme/colors.ts(in particular
linear-gradient(111.68deg, #F2ECF2 0%, #E8F2F6 100%)cardHeaderBackgroundwith thesetheme/colorsvalues