New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVGs #53

Merged

hachiojidev merged 4 commits into pancakeswap:master from Chef-Cheems:fix/svg-fix

Apr 7, 2021

Contributor

Chef-Cheems commented Apr 6, 2021

This PR fixes:

Cropped SVGs in Safari. The issue was that some SVGs use the same id for clip-path, Safari can't figure out which one is used for which SVG and starts cutting wrong SVGs (cause id is matching).
Before

After

Before

After
Linear gradients in SVGs were also broken in a same way - some svgs used same id, which caused the colors to either be completely wrong permanently or flicker on loading.(not only in Safari btw, Chrome also had troubles with it, vids below are from Chrome)
Before

SVGfuckup.mp4

After

SvgGradientFixed.mp4

Chef-Cheems added 2 commits

April 6, 2021 13:40


          fix: Use unique id for svg clip

a5dc7f6


          fix: Fix linear gradient ids in SVGs

1ac44c1

Chef-Cheems requested review from hachiojidev and RabbitDoge as code owners

April 6, 2021 11:10

Chef-Cheems added 2 commits

April 6, 2021 14:17


          fix: Remove unused svg

3dd7983


          fix: Revert color change used for testing

d83bc8e

ChefHutch approved these changes

View reviewed changes

Contributor

ChefHutch left a comment

ty 🥳

hachiojidev approved these changes

View reviewed changes

Contributor

hachiojidev left a comment

Good catch. @RabbitDoge @ChefHutch @Chef-Cheems We need to keep this in mind when exporting from Figma.

hachiojidev merged commit 6eeb5a7 into pancakeswap:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet