fix(uikit): Accept float values for Slider #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hachiojidev
commented
Mar 16, 2021
hachiojidev
commented
- Refactored progress to remove excess class names
hachiojidev
commented
Mar 16, 2021
| <BarProgress | ||
| isMax={isMax} | ||
| progress={progressPercentage} | ||
| style={{ width: isMax ? "calc(100% - 16px)" : `${progressPercentage}%` }} |
There was a problem hiding this comment.
Using inline styles so it doesn't generate a class for each progress tick.
hachiojidev
commented
Mar 16, 2021
|
|
||
| return ( | ||
| <SliderContainer {...props}> | ||
| <Box position="relative" height="48px" {...props}> |
There was a problem hiding this comment.
SliderContainer was not needed
RabbitDoge
approved these changes
Mar 17, 2021
- Refactored progress to remove excess class names
hachiojidev
force-pushed
the
uikit/slider-fixes
branch
from
9cb03a8
to
64ce088
Compare
ChefHutch
pushed a commit
to ChefHutch/pancake-toolkit
that referenced
this pull request
Mar 18, 2021
- Refactored progress to remove excess class names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.