fix: (Menu) Footer is not visible completely when navigation bar is visible in mobile browsers #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
Chef-Chungus,
hachiojidev and
RabbitDoge
as code owners
memoyil
changed the title
hachiojidev
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also so hard to change language in safari when clicking the language button mostly activates navigation bar, and in android it is not visible at first glance unless you scroll it
Before:
WhatsApp.Video.2021-06-04.at.13.13.10.mp4
After:
WhatsApp.Video.2021-06-04.at.13.15.03.mp4
==================
It also fixes language selection menu top part is not visible in small screens (it is under the header bar) when in wallet browsers or safari with navigation bar at the bottom.
Before:
WhatsApp.Video.2021-06-04.at.13.30.15.mp4
After:
WhatsApp.Video.2021-06-04.at.13.29.49.mp4