Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building storybook on windows #107

Closed
ciruz opened this issue May 18, 2021 · 3 comments
Closed

building storybook on windows #107

ciruz opened this issue May 18, 2021 · 3 comments

Comments

@ciruz
Copy link
Contributor

ciruz commented May 18, 2021

Hey guys,

the package.json from the uikit (storybook) contains a rm -rf in the build command, this is not really compatible when building it on windows. I'm unsure if storybook deletes the dist/ folder or cleans it up by itself when building.

"build": "rm -rf ./dist && rollup -c && tsc -d --emitDeclarationOnly --declarationDir dist",

@byCedric
Copy link

It looks like a custom build workflow, so I don't think storybook actually cleans it up for you. But you can replace it with something like rimraf to make it work on Windows. Happy to add a PR for that.

@jasonrsadler
Copy link

rm -rf is the recursive delete for macos/linux. Git Bash for windows will allow you to build properly.

@RabbitDoge
Copy link
Contributor

Nobody in our team works on Window.
You have 2 solutions here:

  • Remove the m -rf ./dist && at the start
  • Use git bash or a similar tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants