Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get(type=) should catch TypeError consistently #2976

Closed
davidism opened this issue Oct 30, 2024 · 2 comments · Fixed by #2978
Closed

get(type=) should catch TypeError consistently #2976

davidism opened this issue Oct 30, 2024 · 2 comments · Fixed by #2978
Assignees
@davidism
Milestone
3.1.0

Comments

@davidism
Copy link
Member

#2842 changed TypeConversionDict.get to catch TypeError in addition to ValueError, but other datastructures with get(type=) were not changed. Make them all consistent.
@davidism davidism added this to the 3.1.0 milestone Oct 30, 2024
@davidism davidism self-assigned this Oct 30, 2024
@davidism
Copy link
Member Author

Headers only has string values, so a type that raised TypeError on any string would be pointless. So Headers.get can be excluded.

@davidism
Copy link
Member Author

Looks like it's only getlist that needs to be updated.

@davidism davidism mentioned this issue Oct 30, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

getlist catches TypeError pallets/werkzeug
1 participant
@davidism