Pyright types fixes #5550
Closed
Pyright types fixes #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendon-codes
force-pushed
the
pyright-types-fixes
branch
from
8e0ec0c
to
7706747
Compare
brendon-codes
force-pushed
the
pyright-types-fixes
branch
from
7706747
to
eeae10c
Compare
brendon-codes
commented
Aug 7, 2024
| @@ -79,6 +79,10 @@ def __init__( | |||
| path = url.path | |||
|
|
|||
| if url.query: | |||
| # NOTE: | |||
There was a problem hiding this comment.
@davidism See note here
|
@davidism Ok I made a new combined issue and a new combined PR. Checks are passing. I left a note in this PR with a question. I will pause on any new code in this PR until I get initial review feedback. |
|
Hi @davidism Anything I should change on this PR? |
|
It looks like you don't have "Maintainers are allowed to edit this pull request." enabled, which means I can't push some additional fixes. I'll close this and open a new PR, unless you see this before I get there. |
|
continued in #5620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various Pyright types errors.
fixes #5549