Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on parking_lot 0.10 #16

Closed
dvtomas opened this issue Feb 4, 2020 · 3 comments · Fixed by #18
Closed

Depend on parking_lot 0.10 #16

dvtomas opened this issue Feb 4, 2020 · 3 comments · Fixed by #18

Comments

@dvtomas
Copy link

dvtomas commented Feb 4, 2020

New version of parking_lot has been released, and I'm getting clashes between my project depending directly on 0.10 and serial_test depending on 0.9. Compilation fails with "Perhaps two different versions of parking_lot are used?"

Maybe serial_test should be updated to depend on parking_lot 0.10 as well?

@palfrey
Copy link
Owner

palfrey commented Feb 4, 2020

Possibly. Only problem with that is that you then get Amanieu/parking_lot#188 pulled in, which means our MSRV has to jump to 1.36. If rust-lang/rust#65262 gets resolved at some point I could leave the version floating a bit more, but for the moment this is slightly annoying.

I'll probably just bump the MSRV and do a 0.4.0 release at some point however.

@dvtomas
Copy link
Author

dvtomas commented Feb 14, 2020

Hey,
thanks for upgrading parking_lot. Do you plan to release new version to crates.io anytime soon?

@palfrey
Copy link
Owner

palfrey commented Feb 14, 2020

I'd been delaying because this and #17 turned up relatively quickly after one another and wanted to wait and see if anything else cropped up before doing a new release, but looks like we're safe for the moment so I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants