newline-before-return false positive

[YKlos]

Bug Report

• TSLint version: 4.5.1
• TypeScript version: 2.2.1
• Running TSLint via: Node.js API

TypeScript code being linted

class HelloWorld {

    test() {
        console.log("Any statement");
        // Any comment

        return;
    }
}

with tslint.json configuration:

"rules":
{
    "newline-before-return": true
}

Actual behavior

If there is a comment between the last statement and the return statement, tslint throws a false positive "Missing blank line before return"

Expected behavior

[sbj42]

Here's another case not covered by the rule:

function foo() {
    fn();
    // comment

    // comment
    return;
}

The if (comments) { ... } block in newlineBeforeReturnRule.ts should probably check if:

• There's a blank line in between one comment and another
• Or there's a blank line after the last comment

Either of those conditions could trigger an early return and no warning.