This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Added an abstract OptionallyTypedRule #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Mar 6, 2017
|
|
||
| export abstract class OptionallyTypedRule extends AbstractRule implements ITypedRule { | ||
|
|
||
| public abstract apply(): RuleFailure[]; |
There was a problem hiding this comment.
this one is inherited by AbstractRule and does not need to be specified here again
Like `AbstractRule`, it provides abstract `apply*` members that must be implemented. *(errata: switched the order of checks in `linter.ts` because it felt quicker having a property check before the function call)* Also moved `isTypedRule` logic to a separate function, as it's no longer unique to the `TypedRule` class. An alternative I'd considered but rejected would be to make a member `isTyped(): this is IRule` on `IRule`, but that would require classes not inheriting from `AbstractRule` to also define their own `isTyped()`. Resolves #2091.
|
@JoshuaKGoldberg thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
AbstractRule, it provides abstractapply*members that must beimplemented.
(errata: switched the order of checks in
linter.tsbecause it feltquicker having a property check before the function call)
Also moved
isTypedRulelogic to a separate function, as it's no longerunique to the
TypedRuleclass. An alternative I'd considered butrejected would be to make a member
isTyped(): this is IRuleonIRule, but that would require classes not inheriting fromAbstractRuleto also define their ownisTyped().Resolves #2091.
[api] Added class
OptionallyTypedRule, which allows rule authors to write a rule that applies when typing is either enabled or disabled