This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Rename no-let-undefined to no-unnecessary-initializer
#2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* And handle 'var', destructuring, and parameter initializers
ajafff
suggested changes
Jan 22, 2017
|
|
||
| const e = undefined; | ||
|
|
||
| function f(x: string | undefined = undefined) {} |
There was a problem hiding this comment.
It should not recommend making a parameter optional if it is followed by a required parameter:
function f(foo: string|undefined = undefined, bar: number) {} // no error, parameter foo cannot be optional
function f2(foo: string|undefined = undefined, bar: number = 1) {} // foo can be optional
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [1]
ajafff
reviewed
Jan 23, 2017
|
|
||
| const e = undefined; | ||
|
|
||
| function f(x: string | undefined = undefined, bar: number) {} |
There was a problem hiding this comment.
On second thought, on this function the = undefined should lead to failure [0].
If parameter bar is required, you need to pass a value for x. So is makes no sense to set a default of undefined, because the default value is only used when the passed value for that parameter is undefined.
nchen63
reviewed
Jan 24, 2017
| /* tslint:disable:object-literal-sort-keys */ | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "no-unnecessary-initializer", | ||
| description: "Forbids a 'var'/'let' statementor destructuring initializer to be initialized to 'undefined'.", |
There was a problem hiding this comment.
statementor -> statement or
ajafff
approved these changes
Jan 24, 2017
|
@andy-hanson thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Handled more things in
no-let-undefined, so changing the name too. See comments on #2100.