no-switch-case-fall-through: Expect break before default

[unional]

Hi, I was expecting no-switch-case-fall-through to catch issues like this:

switch (prop) {
  case 1:
    // do stuff...
    // forget to break....
  case 2:
    // do stuff...
    break;
  default:
    // do stuff...
    break;

But it also catches these:

switch (prop) {
  case 1:
  case 2:
    // do stuff...
    break;
  case 3:
  default:
    // do stuff...
    break;
}

I think that (especially the default case) is a pretty common and valid pattern. What do you think?

[jkillian]

You can add a special /* falls through */ comment, which will tell the rule that you want to allow a fall through to happen. I think

  case 3:
  default:

should be allowed though, seems like a bug in the rule potentially.

[HolgerJeromin]

I think this is a bug as the comment

tslint/src/rules/noSwitchCaseFallThroughRule.ts

Line 40 in e5b5ff1

// no break statements and no statements means the fallthrough is expected.

mention it as a valid case.
And perhaps the test is wrong, too.