From 8b1b785dc721568f732a7731b0053a6a54c1c6b0 Mon Sep 17 00:00:00 2001 From: David Schlosnagle Date: Mon, 9 Dec 2019 15:42:06 -0500 Subject: [PATCH 1/3] Upgrade to gradle-baseline 2.41.0 --- build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index 6903c2f7..2adea3d7 100644 --- a/build.gradle +++ b/build.gradle @@ -14,7 +14,7 @@ buildscript { classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4' classpath 'com.netflix.nebula:gradle-info-plugin:5.2.0' classpath 'com.netflix.nebula:nebula-publishing-plugin:14.1.1' - classpath 'com.palantir.baseline:gradle-baseline-java:2.37.0' + classpath 'com.palantir.baseline:gradle-baseline-java:2.41.0' classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:1.13.1' classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.2' classpath 'com.palantir.metricschema:gradle-metric-schema:0.4.8' From cb31af3862fcb7ebb0094414f09b8b6915b10899 Mon Sep 17 00:00:00 2001 From: David Schlosnagle Date: Mon, 9 Dec 2019 15:44:44 -0500 Subject: [PATCH 2/3] More specific runtime exception --- .../java/com/palantir/tritium/tracing/ReflectiveTracer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tritium-tracing/src/main/java/com/palantir/tritium/tracing/ReflectiveTracer.java b/tritium-tracing/src/main/java/com/palantir/tritium/tracing/ReflectiveTracer.java index 6315ccd6..6e46be75 100644 --- a/tritium-tracing/src/main/java/com/palantir/tritium/tracing/ReflectiveTracer.java +++ b/tritium-tracing/src/main/java/com/palantir/tritium/tracing/ReflectiveTracer.java @@ -90,7 +90,7 @@ private static List paramsToClassNames(Method method) { private static RuntimeException throwUnchecked(ReflectiveOperationException reflectionException) { Throwable cause = reflectionException.getCause() != null ? reflectionException.getCause() : reflectionException; Throwables.throwIfUnchecked(cause); - throw new RuntimeException(cause); + throw new IllegalStateException(cause); } } From da6d70659045ac73fa750fd6713889f0297a8485 Mon Sep 17 00:00:00 2001 From: David Schlosnagle Date: Mon, 9 Dec 2019 17:16:45 -0500 Subject: [PATCH 3/3] Add JavaDoc to InstrumentationFilters --- .../com/palantir/tritium/event/InstrumentationFilters.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tritium-core/src/main/java/com/palantir/tritium/event/InstrumentationFilters.java b/tritium-core/src/main/java/com/palantir/tritium/event/InstrumentationFilters.java index b38e208a..e8ec3c0b 100644 --- a/tritium-core/src/main/java/com/palantir/tritium/event/InstrumentationFilters.java +++ b/tritium-core/src/main/java/com/palantir/tritium/event/InstrumentationFilters.java @@ -22,6 +22,9 @@ public enum InstrumentationFilters implements InstrumentationFilter { + /** + * Instrument all invocations. + */ INSTRUMENT_ALL { @Override public boolean shouldInstrument( @@ -32,6 +35,9 @@ public boolean shouldInstrument( } }, + /** + * Instrument no invocations. + */ INSTRUMENT_NONE { @Override public boolean shouldInstrument(