From 7a8d080da90daab1ba6ab4f42eb76db840963585 Mon Sep 17 00:00:00 2001 From: MartinWitt Date: Sun, 8 Jan 2023 14:26:52 +0000 Subject: [PATCH 1/2] Refactor bad smells: - UnnecessaryToStringCall The toString() method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code. --- .../java/com/palantir/gradle/graal/BaseGraalCompileTask.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java b/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java index 34877177..23714587 100644 --- a/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java +++ b/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java @@ -182,7 +182,7 @@ protected final void configurePlatformSpecifics(ExecSpec spec) { // delayed environment variable expansion via ! cmdArgs.add("/V:ON"); cmdArgs.add("/c"); - cmdArgs.add("\"" + startCmd.toString() + "\""); + cmdArgs.add("\"" + startCmd + "\""); spec.setExecutable("cmd.exe"); spec.setArgs(cmdArgs); } From 5ba801db73f3b167e7d42d305262a2ba73e32139 Mon Sep 17 00:00:00 2001 From: MartinWitt Date: Sun, 8 Jan 2023 15:27:54 +0100 Subject: [PATCH 2/2] Update BaseGraalCompileTask.java --- .../java/com/palantir/gradle/graal/BaseGraalCompileTask.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java b/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java index 23714587..8c4e04f4 100644 --- a/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java +++ b/src/main/java/com/palantir/gradle/graal/BaseGraalCompileTask.java @@ -182,7 +182,7 @@ protected final void configurePlatformSpecifics(ExecSpec spec) { // delayed environment variable expansion via ! cmdArgs.add("/V:ON"); cmdArgs.add("/c"); - cmdArgs.add("\"" + startCmd + "\""); + cmdArgs.add("\"" + startCmd + "\""); spec.setExecutable("cmd.exe"); spec.setArgs(cmdArgs); }