Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwitchStatementDefaultCase clashes with MissingCasesInEnumSwitch #499

Closed
markelliot opened this issue Jan 10, 2019 · 2 comments · Fixed by #1309
Closed

SwitchStatementDefaultCase clashes with MissingCasesInEnumSwitch #499

markelliot opened this issue Jan 10, 2019 · 2 comments · Fixed by #1309
Labels
error-prone

Comments

@markelliot
Copy link
Contributor

What happened?

Removed default from switch statement per SwitchStatementDefaultCase, now receive MissingCasesInEnumSwitch instead.

What did you want to happen?

Revert/disable SwitchStatementDefaultCase or otherwise make it smarter.
@a-k-g
Copy link
Contributor

a-k-g commented Aug 30, 2019

I tried to repro this, but couldn't. Maybe there was some enum value actually missing in the switch..case?

@a-k-g
Copy link
Contributor

a-k-g commented Aug 30, 2019

or maybe a bug in error-prone that has since been fixed?

@pkoenig10 pkoenig10 mentioned this issue Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
error-prone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove SwitchStatementDefaultCase error-prone check palantir/gradle-baseline
3 participants
@markelliot @a-k-g @iamdanfox