Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenTelemetry Java Instrumentation 2.0.0+ #113

Closed
ThomasVitale opened this issue Jan 15, 2024 · 7 comments · Fixed by #132
Closed

Add support for OpenTelemetry Java Instrumentation 2.0.0+ #113

ThomasVitale opened this issue Jan 15, 2024 · 7 comments · Fixed by #132
Assignees
Labels
type:enhancement A general enhancement

Comments

@ThomasVitale
Copy link
Collaborator

ThomasVitale commented Jan 15, 2024

Describe the Enhancement

The new major release train of OpenTelemetry Java Instrumentation introduces several breaking change. This enhancement is to prepare a new major release of this buildpack to add support for it, and handle carefully the release process to avoid affecting existing users of this buildpack.

Release notes: https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v2.0.0

Context

See: #112

@anthonydahanne
Copy link
Member

@ThomasVitale @dmikusa Hello 👋
May is in a month, should we switch the library now and bump the major to 2 ?

@ThomasVitale
Copy link
Collaborator Author

@anthonydahanne yeah, it seems a good time for that. I'll start working on this and submit a PR soon

@ThomasVitale ThomasVitale self-assigned this Apr 11, 2024
@tudburley
Copy link

Hi, is there any time schedule when the update to OpenTelemetry 2.4 will be done? As mentioned here, OTel 1.32.x is only supported until May.

@ThomasVitale
Copy link
Collaborator Author

@tudburley As soon as this PR is merged, we should be able to cut a new release: #132 @dmikusa what do you think?

@dmikusa
Copy link
Contributor

dmikusa commented Jun 6, 2024

Hi all, we've released paketo-buildpacks/opentelemetry@2.0.0 which has the 2.4.0 agent. Please give it a try and let me know if you have any issues.

@ThomasVitale thanks for the PR!

@ThomasVitale
Copy link
Collaborator Author

@dmikusa great, thank you!

I took the chance to update the OpenTelemetry sample here and test the new buildpack version with the current version of Spring Boot: paketo-buildpacks/samples#738

@StefanLobbenmeierObjego

FYI there is a slight breaking change in opentelemetry v2, because it changed from http to grpc by default. We export to tempo, so it was just a matter of replacing the OTEL_EXPORTER_OTLP_ENDPOINT port from 4317 to 4318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants